Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-38438: New interface to save the generated role #1775

Merged
merged 2 commits into from
Jan 22, 2025
Merged

AAP-38438: New interface to save the generated role #1775

merged 2 commits into from
Jan 22, 2025
+274 −74

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Jan 21, 2025

No description provided.

@goneri goneri requested review from a team as code owners January 21, 2025 19:49
alisonlhart
alisonlhart reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@alisonlhart alisonlhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I only have a couple of cleanup suggestions, nothing critical.

src/webview/apps/lightspeed/roleGeneration/main.ts Outdated Show resolved Hide resolved
src/webview/apps/lightspeed/roleGeneration/main.ts Outdated Show resolved Hide resolved
@alisonlhart alisonlhart mentioned this pull request Jan 21, 2025
Closed
@goneri goneri force-pushed the goneri/AAP-38438-New-interface-to-save-the-generated-role_32192 branch from e25ce99 to df979bd Compare January 21, 2025 22:15
alisonlhart
alisonlhart approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@alisonlhart alisonlhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎊

@goneri goneri force-pushed the goneri/AAP-38438-New-interface-to-save-the-generated-role_32192 branch from c8b82c0 to ccd5226 Compare January 22, 2025 16:11
@goneri goneri enabled auto-merge (rebase) January 22, 2025 17:21
@goneri goneri disabled auto-merge January 22, 2025 18:38
@goneri goneri enabled auto-merge (rebase) January 22, 2025 18:39
@goneri goneri disabled auto-merge January 22, 2025 18:39
@goneri goneri merged commit ff5ab6e into main Jan 22, 2025
13 of 15 checks passed
@goneri goneri deleted the goneri/AAP-38438-New-interface-to-save-the-generated-role_32192 branch January 22, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonlhart alisonlhart alisonlhart approved these changes

@mabashian mabashian mabashian approved these changes

Assignees
No one assigned
Labels
minor
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goneri @mabashian @alisonlhart