Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cascader-view's demo type fix #6445

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

1587315093
Copy link
Contributor

demo代码里的小提示修复

image

@@ -5,7 +5,7 @@ import { DemoBlock } from 'demos'
import { options, sameValueOptions } from '../../cascader/demos/data'

export default () => {
const [value, setValue] = useState<string[]>([])
const [value, setValue] = useState<Array<string | number>>([])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉 (string | number)[] 会更简单一些~~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没问题~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉 (string | number)[] 会更简单一些~~

done

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6445.surge.sh

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (671ea15) 92.10% compared to head (d6d2891) 92.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6445   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files         316      316           
  Lines        6861     6861           
  Branches     1719     1719           
=======================================
  Hits         6319     6319           
  Misses        504      504           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit abef05c into ant-design:master Nov 21, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants