Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL scanning can run always on all code #45541

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 10, 2025

The CodeQL scannig is fast and having custom configuration to select which scanning to run should be run makes it unnecessarily complex

We can just run all CodeQL scans always.

This has been suggested by actions codeql scan itself.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk marked this pull request as ready for review January 10, 2025 09:00
@potiuk potiuk requested a review from ashb as a code owner January 10, 2025 09:00
The CodeQL scannig is fast and having custom configuration to
select which scanning to run should be run makes it unnecessarily
complex

We can just run all CodeQL scans always.

This has been suggested by actions codeql scan itself.
@potiuk potiuk force-pushed the simplify-codeql-scanning-job-conditions branch from 46060b8 to 2b70c82 Compare January 10, 2025 10:14
@potiuk potiuk merged commit a149dd7 into apache:main Jan 10, 2025
17 checks passed
@potiuk potiuk deleted the simplify-codeql-scanning-job-conditions branch January 10, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants