Improve ListArray documentation for slices
#7039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @rluvaton |
tustvold
approved these changes
Jan 28, 2025
|
FWIW the same behaviour applies to StringArray and LargeStringArray, not sure if we need something similar documented there. There is also something similar for the ViewArray types |
rluvaton
reviewed
Jan 28, 2025
rluvaton
reviewed
Jan 28, 2025
rluvaton
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Maybe add a helper function to know if can use the values and offsets as is? it will be useful for the concat and for other cases when doing optimization regarding list operation
There was a problem hiding this comment.
Sounds like a good follow on PR. Thanks @rluvaton
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
rluvaton
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ListArrays is broken #7034Rationale for this change
It was very unclear to me (at first) what I could assume /not assume about a
ListArarysvalues()andoffsetsarrays when working on #7037Now that I have studied the code for a while I would like to add documentatation to save myself (and hopefully others) from this trouble again
What changes are included in this PR?
LIstArrayandsliceAre there any user-facing changes?
Only docs, no functional changes
Also with ASCII art (I can't help myself)