Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use randbytes in custom LCG random generator #33557

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 10, 2025

follow up #33510

  • It's internal and test only code, fine to change method name

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* It's internal and test only code, fine to change method name
@Abacn
Copy link
Contributor Author

Abacn commented Jan 10, 2025

beam_PreCommit_PythonDocker is misconfigured. It actually runs a small scale load test, which running against "gcr.io/apache-beam-testing/beam-sdk/beam_python3.9_sdk:latest", not on the PR change. and that's why the issue not found in #33510

The test should be back green 4h after this PR check in

@Abacn
Copy link
Contributor Author

Abacn commented Jan 10, 2025

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Jan 10, 2025

created #33558 to track the test workflow issue

Copy link
Contributor

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit 6b3bca3 into apache:master Jan 10, 2025
89 of 91 checks passed
@Abacn Abacn deleted the fixmethodname branch January 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants