-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/enrichment docs #33012 #33561
Fix/enrichment docs #33012 #33561
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label website. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this one
|
||
## Caching with `with_redis_cache` | ||
|
||
For frequently used enrichment data, caching can significantly improve performance by reducing repeated calls to the remote service. Apache Beam's `with_redis_cache` method allows you to integrate a Redis cache into the enrichment pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from apache_beam.transforms.enrichment import with_redis_cache | ||
|
||
# Enrichment pipeline with Redis cache | ||
enriched_data = (input_data | ||
| 'Enrich with Cache' >> with_redis_cache(redis_config=redis_config, enrichment_transform=my_enrichment_transform)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this generated code is right, with_redis_cache
should be appended to the enrichment transform like this -
| Enrichment(handler).with_redis_cache(self.host, self.port)) |
" | 2 | Y | 10 | P |\n", | ||
" | 2 | Y | 20 | Q |\n", | ||
"\n", | ||
"Cross-joins can be computationally expensive for large datasets, so use them judiciously.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you combine this cell and the next one into a single cell? I think they're discussing the same thing.
Co-authored-by: Danny McCormick <dannymccormick@google.com>
…athi/beam into fix/enrichment-docs
@damccorm Sir , I made changes, as you specified, please review it and let me know if there is any mistake , Thanks for help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll make a couple tweaks then merge
website/www/site/content/en/documentation/transforms/python/elementwise/enrichment.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/transforms/python/elementwise/enrichment.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/transforms/python/elementwise/enrichment.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/transforms/python/elementwise/enrichment.md
Outdated
Show resolved
Hide resolved
…ementwise/enrichment.md
…ementwise/enrichment.md
…ementwise/enrichment.md
Description
fixes #<33012>
This pull request updates the enrichment documentation and related notebooks with the following improvements:
Documentation:
Added mention of BigQuery in the enrichment section.
Described the batching process and caching mechanism (with_redis_cache).
Notebooks:
Elaborated on the concept of cross-joins in both the bigtable_enrichment_transform.ipynb and vertex_ai_feature_store_enrichment.ipynb notebooks, with a more detailed explanation and added visual examples.
I could not fix the broken link because I think that resource may have been deleted.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.