Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Add AlloyDB vector writer. (#33841) #33880

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Feb 5, 2025

Cherry-pick of #33841


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Add AlloyDB vector writer.

* Resolve comments.

* Add default ConflictResolution as ON CONFLICT DO NOTHING.

* Disable tests.

* Fix docstring errors.

* Simplify ColumnSpec's usage, add builder class to make it obvious what is default and how to override defaults or go full custom.

* Fix linter error.
@damccorm
Copy link
Contributor Author

damccorm commented Feb 5, 2025

R: @claudevdm @jrmccluskey

@github-actions github-actions bot added the python label Feb 5, 2025
Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm merged commit e790cce into release-2.63 Feb 5, 2025
90 checks passed
@damccorm damccorm deleted the users/damccorm/33841-cp branch February 5, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants