Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](iceberg docker)Add health check for iceberg rest container #46767

Merged
merged 10 commits into from
Jan 23, 2025
Merged

[opt](iceberg docker)Add health check for iceberg rest container #46767

merged 10 commits into from
Jan 23, 2025

Conversation

Thearas
Copy link
Contributor

@Thearas Thearas commented Jan 10, 2025

What problem does this PR solve?

Problem Summary:
Add health check for iceberg rest container and minio.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor Author

Thearas commented Jan 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Thearas
Copy link
Contributor Author

Thearas commented Jan 10, 2025

run buildall

@Thearas
Copy link
Contributor Author

Thearas commented Jan 10, 2025

run external

@Thearas
Copy link
Contributor Author

Thearas commented Jan 10, 2025

run buildall

@Thearas
[opt](iceberg docker)Add health check for iceberg rest container
0e5b5db 
Change-Id: I27cbd34871136b0dafb38551bb20be478c2198b9
@Thearas
update
7b19fc4 
Change-Id: I5fae332a9546232a125b486eb179b55aae70cc63
@Thearas
add --wait at docker compose up
e9213b8 
Change-Id: Ic00732a0205e5f293dd52abba59a4283973c4e17
@Thearas Thearas force-pushed the iceberg-rest-health-check branch from 91816e5 to e9213b8 Compare January 21, 2025 03:20
@Thearas
Copy link
Contributor Author

Thearas commented Jan 21, 2025

run buildall

@Thearas
depends_on service healty
d9403c9 
Change-Id: Id22af7ee63a2b13cf4fd8676e25e8da6fcca3c4e
@Thearas
Copy link
Contributor Author

Thearas commented Jan 21, 2025

run external

@Thearas
Copy link
Contributor Author

Thearas commented Jan 21, 2025

run buildall

@Thearas
update
a77ae36 
Change-Id: I8f9205159ad882f70ea7c602096454a067927f12
@Thearas
Copy link
Contributor Author

Thearas commented Jan 21, 2025

run buildall

@Thearas
update
edc8e9b 
Change-Id: Ida8d0431a38b7d9b1a13f1bc383ace9c11f36219
@Thearas Thearas force-pushed the iceberg-rest-health-check branch from 0afe5dd to 0e07155 Compare January 22, 2025 07:30
@Thearas
update
bce7d1d 
Change-Id: I7ebd78eddb0e5d584957ece4210a9c5c883eb306
@Thearas Thearas force-pushed the iceberg-rest-health-check branch from 0e07155 to bce7d1d Compare January 22, 2025 09:23
@Thearas
Copy link
Contributor Author

Thearas commented Jan 22, 2025

run buildall

@Thearas
Copy link
Contributor Author

Thearas commented Jan 22, 2025

Minio started failed, I'm trying a newer Minio.
image

@Thearas
update
2c35dce 
Change-Id: I021b823247a51100686092adaccf995cc9eec806
@Thearas Thearas force-pushed the iceberg-rest-health-check branch from a7a9d31 to 2c35dce Compare January 22, 2025 13:48
@Thearas
Copy link
Contributor Author

Thearas commented Jan 23, 2025

run buildall

@Thearas
update
a5c2066 
Change-Id: I0e6f9ef8c4356c6fa67b88d9603b22c4d4cd13bc
@Thearas
update
66395b0 
Change-Id: I7495e6e88065347ab96bb0a12ef49d9c8e44a7b6
@Thearas
Copy link
Contributor Author

Thearas commented Jan 23, 2025

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 23, 2025
MoanasDaddyXu
MoanasDaddyXu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@MoanasDaddyXu MoanasDaddyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen hello-stephen merged commit fad3960 into apache:master Jan 23, 2025
25 of 26 checks passed
@Thearas Thearas deleted the iceberg-rest-health-check branch January 23, 2025 08:25
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@Thearas
[opt](iceberg docker)Add health check for iceberg rest container (#46767
7107807 
)

### What problem does this PR solve?

Problem Summary:
Add health check for iceberg rest container and minio.
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Open
Thearas added a commit to Thearas/doris that referenced this pull request Jan 24, 2025
@Thearas
[opt](iceberg docker)Add health check for iceberg rest container (apa…
bcbf4a6 
…che#46767)

### What problem does this PR solve?

Problem Summary:
Add health check for iceberg rest container and minio.
yiguolei pushed a commit that referenced this pull request Jan 25, 2025
@Thearas
[opt](iceberg docker)Add health check for iceberg rest container (#46767
7c9d64d 
) (#47422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgxme zgxme zgxme approved these changes

@MoanasDaddyXu MoanasDaddyXu MoanasDaddyXu approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thearas @hello-stephen @zgxme @MoanasDaddyXu