-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the md5 of the metadata cache file #15006
base: 3.3
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15006 +/- ##
============================================
+ Coverage 58.88% 60.75% +1.86%
- Complexity 12 10866 +10854
============================================
Files 1882 1882
Lines 86004 86012 +8
Branches 12884 12884
============================================
+ Hits 50644 52254 +1610
+ Misses 29835 28307 -1528
+ Partials 5525 5451 -74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -212,6 +207,15 @@ public synchronized String calAndGetRevision() { | |||
return revision; | |||
} | |||
|
|||
public String calRevision() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to add a lock here to prevent concurrent modification.
BTW, please check other operation will aquire lock
What is the purpose of the change?
The local cache file may be damaged for various reasons, resulting in a no provider exception, check the consistency of md5 can avoid this problem.
Checklist