[FLINK-37206][Runtime] Fix initialization of batching timer service in async state operators #26071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zakelly
commented
Jan 24, 2025
| * Sets the current key. Timers that are due to be fired are collected and will be triggered. | ||
| */ | ||
| @Override | ||
| public void setCurrentKey(K currentKey) throws Exception { |
There was a problem hiding this comment.
The core difference between timer service for async operators and the original one is here. Replace direct call of triggerTarget.onXXXXXTime() with a wrapper of maintainContextAndProcess
|
@fredia @codenohup Would you please take a look? |
|
Thanks @codenohup ! |
fredia
approved these changes
Jan 24, 2025
| } else if (factory instanceof AsyncKeyedStateBackendAdaptor) { | ||
| theFactory = | ||
| (BatchExecutionKeyedStateBackend<K>) | ||
| ((AsyncKeyedStateBackendAdaptor<K>) factory).getKeyedStateBackend(); |
There was a problem hiding this comment.
Check ((AsyncKeyedStateBackendAdaptor<K>) factory).getKeyedStateBackend() is BatchExecutionKeyedStateBackend here?
And update the description of IllegalStateException below.
There was a problem hiding this comment.
Updated accordingly.
fredia
approved these changes
Jan 24, 2025
…n async state operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We have ship two abstract stream operators for async state processing, where a async timer service (manager) is introduced. Actually these operators can run in sync mode, this is especially the case for batch execution mode. Currently there is an issue when initializing batching timer service in those operators. This PR fixes this to enable batch execution for operators with async state.
Brief change log
BatchExecutionInternalTimeServiceWithAsyncStateand properly create this in async state operators.Verifying this change
This change added test
BatchExecutionInternalTimeServiceWithAsyncStateTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation