Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect the query statistics calc logic of fe #14183

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Nov 22, 2024

Description

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Beyyes Beyyes marked this pull request as draft November 22, 2024 11:14
@Beyyes Beyyes changed the title Perfect the query statistics calc method of fe Perfect the query statistics calc logic of fe Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 54.76190% with 38 lines in your changes missing coverage. Please review.

Project coverage is 39.64%. Comparing base (65ab3ea) to head (55a18c3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...stics/FixedScheduledOutputQueryPlanStatistics.java 39.13% 28 Missing ⚠️
.../apache/iotdb/db/queryengine/plan/Coordinator.java 25.00% 3 Missing ⚠️
.../db/queryengine/plan/execution/QueryExecution.java 0.00% 3 Missing ⚠️
...yengine/plan/execution/config/ConfigExecution.java 0.00% 2 Missing ⚠️
.../db/queryengine/plan/planner/TreeModelPlanner.java 0.00% 1 Missing ⚠️
...ine/plan/relational/planner/TableModelPlanner.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14183      +/-   ##
============================================
+ Coverage     39.63%   39.64%   +0.01%     
  Complexity       71       71              
============================================
  Files          4224     4231       +7     
  Lines        269541   269666     +125     
  Branches      32681    32684       +3     
============================================
+ Hits         106833   106922      +89     
- Misses       162708   162744      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant