Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak while inserting using sql #14733

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix memory leak while inserting using sql #14733

merged 2 commits into from
Jan 21, 2025

Conversation

JackieTien97
Copy link
Contributor

Fix memory leak:

  1. inserting using sql
  2. fetching all result but forgetting calling Dataset.close

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.

Project coverage is 39.29%. Comparing base (fea2e4f) to head (f1b2043).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../db/protocol/thrift/impl/ClientRPCServiceImpl.java 0.00% 19 Missing ⚠️
...pache/iotdb/db/protocol/session/ClientSession.java 0.00% 10 Missing ⚠️
...tdb/db/protocol/session/InternalClientSession.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14733      +/-   ##
============================================
+ Coverage     39.27%   39.29%   +0.01%     
  Complexity      193      193              
============================================
  Files          4420     4420              
  Lines        281458   281479      +21     
  Branches      34804    34807       +3     
============================================
+ Hits         110556   110615      +59     
+ Misses       170902   170864      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@JackieTien97 JackieTien97 merged commit 9f8bf85 into master Jan 21, 2025
45 of 47 checks passed
@JackieTien97 JackieTien97 deleted the releaseQueryId branch January 21, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants