Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the log of table cache update #14734

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Conversation

Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Jan 20, 2025

Description

As the title said.
By test, 1000000 columns - 1000000 columns comparison costs 300ms by average.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add performance test for your compareTable, number of columns should be greater than 200,000

@Caideyipi
Copy link
Collaborator Author

add performance test for your compareTable, number of columns should be greater than 200,000

By test, 1000000 - 1000000 comparison costs 300ms by average... Shall this be put in CI? On GH it won't be useful, or just leave a @ignore there...

@JackieTien97 JackieTien97 merged commit 8b6311b into apache:master Jan 21, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants