Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Model Subquery] Support Exists subquery #14739

Open
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

lancelly
Copy link
Contributor

@lancelly lancelly commented Jan 21, 2025

This PR introduces both correlated and uncorrelated Exists subquery into IoTDB TableModel.
Correlated subquery has such limitations:

  1. limit clause with row count greater than 1 is not supported in correlated subquery for now.
  2. TopK clause is not supported in correlated subquery for now.
  3. Non-Equality comparison is not supported in correlated subquery for now.(Error msg for this is kind of confusing since it's related to join: For now, FullOuterJoin and LeftJoin only support EquiJoinClauses )

@lancelly lancelly changed the title [Table Model Subquery] Support correlated Exists subquery [Draft][Table Model Subquery] Support correlated Exists subquery Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 42.60355% with 679 lines in your changes missing coverage. Please review.

Project coverage is 39.57%. Comparing base (8c62821) to head (8403245).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...formCorrelatedGlobalAggregationWithProjection.java 20.35% 90 Missing ⚠️
...mCorrelatedGlobalAggregationWithoutProjection.java 18.44% 84 Missing ⚠️
...al/planner/optimizations/PlanNodeDecorrelator.java 66.66% 72 Missing ⚠️
...ormCorrelatedGroupedAggregationWithProjection.java 29.76% 59 Missing ⚠️
...CorrelatedGroupedAggregationWithoutProjection.java 25.00% 54 Missing ⚠️
...r/source/relational/MergeSortLeftJoinOperator.java 0.00% 50 Missing ⚠️
...rmCorrelatedDistinctAggregationWithProjection.java 33.84% 43 Missing ⚠️
...ution/operator/process/AssignUniqueIdOperator.java 0.00% 41 Missing ⚠️
...orrelatedDistinctAggregationWithoutProjection.java 29.62% 38 Missing ⚠️
...nner/optimizations/PushPredicateIntoTableScan.java 61.44% 32 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14739      +/-   ##
============================================
+ Coverage     39.21%   39.57%   +0.36%     
  Complexity      193      193              
============================================
  Files          4448     4497      +49     
  Lines        282681   286239    +3558     
  Branches      34868    35431     +563     
============================================
+ Hits         110857   113283    +2426     
- Misses       171824   172956    +1132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lancelly lancelly marked this pull request as ready for review January 24, 2025 04:45
@lancelly lancelly changed the title [Draft][Table Model Subquery] Support correlated Exists subquery [Table Model Subquery] Support correlated Exists subquery Jan 24, 2025
@lancelly lancelly changed the title [Table Model Subquery] Support correlated Exists subquery [Table Model Subquery] Support Exists subquery Jan 24, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.0% Duplication on New Code (required ≤ 5%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Beyyes Beyyes self-requested a review January 25, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant