Fix wrong deviceId after PartialPath.concatAsMeasurementPath #14750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuwenwei
approved these changes
Jan 21, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14750 +/- ##
============================================
+ Coverage 39.28% 39.30% +0.02%
Complexity 193 193
============================================
Files 4420 4420
Lines 281463 281524 +61
Branches 34806 34817 +11
============================================
+ Hits 110572 110661 +89
+ Misses 170891 170863 -28 ☔ View full report in Codecov by Sentry. |
JackieTien97
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Fix incorrect DeviceId after concatenation * add it * revert config (cherry picked from commit a681582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deviceId is re-generated after PartialPath.concatAsMeasurementPath, which may be incorrect because it is recalculated by the default rule.
The result is that the wrong deviceId cannot be matched by existing mod entries, causing data to re-appear after compaction.
To fix it, the result of PartialPath.concatAsMeasurementPath will inherit the deviceId from the parameter.