Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query error after insert an all null aligned tablet and flush #14777

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

HTHou
Copy link
Contributor

@HTHou HTHou commented Jan 25, 2025

Description

As title.

How To Test.

// Insert aligned tablet with null values
String deviceId = "root.sg1.clsu.aligned_d1";
Tablet tablet =
    new Tablet(
        deviceId,
        Arrays.asList(
            new MeasurementSchema("s1", TSDataType.BOOLEAN),
            new MeasurementSchema("s2", TSDataType.INT32)),
        3);
tablet.addTimestamp(0, 300);
tablet.addValue("s1", 0, null);
tablet.addValue("s2", 0, null);
tablet.addTimestamp(1, 400);
tablet.addValue("s1", 1, null);
tablet.addValue("s2", 1, null);
tablet.addTimestamp(2, 500);
tablet.addValue("s1", 2, null);
tablet.addValue("s2", 2, null);
session.insertAlignedTablet(tablet);

Then execute

select count(s1) from root.sg1.clsu.aligned_d1

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.48%. Comparing base (25128fc) to head (1eca24e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...e/dataregion/memtable/AlignedWritableMemChunk.java 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14777   +/-   ##
=========================================
  Coverage     39.48%   39.48%           
  Complexity      193      193           
=========================================
  Files          4482     4482           
  Lines        285114   285122    +8     
  Branches      35322    35326    +4     
=========================================
+ Hits         112584   112590    +6     
- Misses       172530   172532    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HTHou HTHou merged commit 9c9b239 into master Jan 26, 2025
38 checks passed
@HTHou HTHou deleted the fix_insert_all_null_tablet branch January 26, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants