[PATCH] stm32 timers: add set/get prescaler operations and get period operation to ll_ops. #15482
+80
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add get period operation to ll_ops.
github-actions
bot
added
Arch: arm
|
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. The author has only provided a very brief title and has not filled out the required sections for Summary, Impact, or Testing. They need to provide detailed information in each of those sections according to the template. Simply saying "add get period operation to ll_ops" is insufficient. |
xiaoxiang781216
approved these changes
Jan 10, 2025
raiden00pl
reviewed
Jan 10, 2025
| #define STM32_TIM_CHECKINT(d,s) ((d)->ops->checkint(d,s)) | ||
| #define STM32_TIM_ENABLE(d) ((d)->ops->enable(d)) | ||
| #define STM32_TIM_DISABLE(d) ((d)->ops->disable(d)) | ||
| #define STM32_TIM_SETMODE(d,mode) ((d)->ops->setmode(d,mode)) |
There was a problem hiding this comment.
do we need this? new ops should match the old alignment
raiden00pl
requested changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.