THRIFT-5811: Update eslint & prettier #3087
Open
+4,732
−4,415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update is necessary to be able to lint dynamic imports in apache#3083. Eslint have changed config formats, to use a "flat config". This means the `.eslintrc.json` and `.eslintignore` have been merged into one file.
cameron-martin
changed the title
The new version of prettier formats code slightly differently, so this runs it over the entire codebase.
cameron-martin
force-pushed
the
update-eslint
branch
from
4740938 to
a8a2ca9
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is necessary to be able to lint dynamic imports in #3083.
Eslint have changed config formats, to use a "flat config". This means the
.eslintrc.jsonand.eslintignorehave been merged into one file,eslint.config.mjs.No new eslint issues were introduced by this upgrade, but prettier formatting has changed a lot. I have put the prettier reformatting into a separate commit for ease of review, but I can squash before merging if this is desired.
[skip ci]anywhere in the commit message to free up build resources.