Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Remove ensureUuid() #6075

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[runtime] Remove ensureUuid() #6075

merged 1 commit into from
Jul 24, 2024

Conversation

martinbonnin
Copy link
Contributor

WebSocketNetworkTransport already has logic to renew the uuid. It's working as long as there's a single Flow instance so memoize it. Makes it even simpler to implement retry interceptors.

See #6069 (comment)

@martinbonnin martinbonnin requested review from a team and BoD as code owners July 24, 2024 10:08
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for apollo-android-docs ready!

Name Link
🔨 Latest commit ca567f9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66a0d29dd99c4d00088dc788
😎 Deploy Preview https://deploy-preview-6075--apollo-android-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 6492256 into main Jul 24, 2024
9 checks passed
@martinbonnin martinbonnin deleted the remove-ensure-uuid branch July 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants