Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next with main #3107

Merged
merged 50 commits into from
Aug 6, 2024
Merged

Update next with main #3107

merged 50 commits into from
Aug 6, 2024

Conversation

dylan-apollo
Copy link
Member

No description provided.

Meschreiber and others added 30 commits June 27, 2024 09:50
Adds redirects for the new quickstart and adds some clarifying notes
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/composition@2.8.2

### Patch Changes

- Updated dependencies
\[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]:
    -   @apollo/federation-internals@2.8.2
    -   @apollo/query-graphs@2.8.2

## @apollo/gateway@2.8.2

### Patch Changes

- Updated dependencies
\[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]:
    -   @apollo/federation-internals@2.8.2
    -   @apollo/composition@2.8.2
    -   @apollo/query-planner@2.8.2

## @apollo/federation-internals@2.8.2

### Patch Changes

- generateQueryFragments() could generate fragments with naming
collisions when nested
([#3043](#3043))

## @apollo/query-graphs@2.8.2

### Patch Changes

- Updated dependencies
\[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]:
    -   @apollo/federation-internals@2.8.2

## @apollo/query-planner@2.8.2

### Patch Changes

- Updated dependencies
\[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]:
    -   @apollo/federation-internals@2.8.2
    -   @apollo/query-graphs@2.8.2

## @apollo/subgraph@2.8.2

### Patch Changes

- Updated dependencies
\[[`b2e5ab66f84688ec304cfcf2c6f749c86aded549`](b2e5ab6)]:
    -   @apollo/federation-internals@2.8.2

## apollo-federation-integration-testsuite@2.8.2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR reverts #3054, as this changes the output of composition for most users and should instead land in `next` instead of `main`.
For very large graphs cloning types with lots of join directives can be expensive. Since these directives will not be used in the Schema that is cloned for toAPISchema(), add the ability to optionally omit them
When working with elements with many referencers, `addReferencer()`
became very hot.
    
If you have eg. 100 referencers, each one is added one by one, and each
new addition iterates the entire existing referencers list. This could
cause quadratic performance.

This changes the `_referencers` values to be JS `Set`s. This maintains
the same order for algorithms that rely on order.

---------

Co-authored-by: Renée Kooi <renee.kooi@apollographql.com>
This PR adds a changeset file for #3056.
For condition resolution, we use a cache that supports caching data per query graph node or edge.

This cache's code was pre-allocating arrays that would almost always be sparsely populated, and for large schemas this overhead is significant. This PR changes these arrays into maps.
While looking at satisfiability validations, @duckki noticed that we were throwing away dead-end/unadvanceable data. I wanted to check whether we could use closures to avoid executing dead-logic entirely unless it's needed (when no options are found for a path), and it turns out it's possible (specifically, the closure's state ends up being immutable, so delaying execution shouldn't change behavior). This PR accordingly wraps the dead-end logic with closures, and only executes them when needed for generating satisfiability errors.
The goal of this commit is to switch from using a dense array for the
various 'sources' passed around in mergeType code, to using a Map
instead. These Map structures have the potential to omit many elements
corresponding to irrelevant subgraphs, becoming sparser than an array,
but this commit preserves the dense array-like behavior, for now.
Since we already loop over all input sources to add shallow versions of
fields to the dest object in addFieldsShallow, we can return a
representation of what was added to be used later in mergeObject,
mergeInterface, and mergeInput, yielding a speedup.

The source of the speedup is the use of sparse Sources maps, so not all
subgraphs need to have an entry in Sources, though some subgraphs still
do have (intentionally) undefined entries, indicating the subgraph does
not contribute a particular field, but might matter for validation of
the field.

I'm aware JavaScript also supports "sparse arrays" which are Array
objects with "holes" in them (missing elements, not just undefined), but
not all operations (such as sparseArray.entries()) skip the holes, so it
seemed better/safer to use an explicitly sparse data structure like Map.
…ype-sources

Use sparse `Map`s rather than dense `sources` arrays in `mergeType` code.
Only run override validation when field has an `@override` in at least one subgraph
…ld_value_hints

Inconsistent value type hints should not be duplicated per subgraph
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to
version-2.8.3-beta, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-2.8.3-beta` is currently in **pre mode** so this branch has
prereleases rather than normal releases. If you want to exit
prereleases, run `changeset pre exit` on `version-2.8.3-beta`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @apollo/composition@2.8.3-beta.0

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Add a fast path to skip override validation for fields without any
subgraph `@override`s.
([#3070](#3070))

- Type merging now uses maps instead of sparsely-populated arrays for
per-subgraph data.
([#3069](#3069))

- Stop duplicating hints for inconsistent value type fields per
subgraph.
([#3071](#3071))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3-beta.0
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/gateway@2.8.3-beta.0

### Patch Changes

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`67b70c6e68b1cdbf8f03dacafd636e27ed9b7814`](67b70c6),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`f5f6a799d6b3675eecb0eaec7a816d746cd136b2`](f5f6a79),
[`42bd27af6a23bcfdd36951dbfa3fb9f7ba833f3a`](42bd27a),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/composition@2.8.3-beta.0
    -   @apollo/query-planner@2.8.3-beta.0
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/federation-internals@2.8.3-beta.0

### Patch Changes

- For very large graphs cloning types with lots of join directives can
be expensive. Since these directives will not be used in the Schema that
is cloned for toAPISchema(), add the ability to optionally omit them
([#3053](#3053))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

## @apollo/query-graphs@2.8.3-beta.0

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Updated dependencies
\[[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/query-planner@2.8.3-beta.0

### Patch Changes

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3-beta.0
    -   @apollo/federation-internals@2.8.3-beta.0

## @apollo/subgraph@2.8.3-beta.0

### Patch Changes

- Updated dependencies
\[[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3-beta.0

## apollo-federation-integration-testsuite@2.8.3-beta.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Updates uses of "Apollo Router" to "GraphOS Router" or "Apollo Router
Core" where necessary
Updates "Who is Apollo" text and links.
This PR fixes the issue identified in [this review
comment](#3069 (comment)).
Specifically, this PR fixes the bug in composition hint/error message
generation where missing sources were computed incorrectly. (No
changeset needed since the referenced PR hasn't been released yet.)
This PR adds a changeset file for #3075 (even though it's not really
necessary for the eventual patch release, it turns out we need it for
the changesets GH action to auto-file the PR).
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to
version-2.8.3-beta, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-2.8.3-beta` is currently in **pre mode** so this branch has
prereleases rather than normal releases. If you want to exit
prereleases, run `changeset pre exit` on `version-2.8.3-beta`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @apollo/composition@2.8.3-beta.1

### Patch Changes

- Fix logic to compute missing subgraphs when generating composition
hints/errors
([#3076](#3076))

-   Updated dependencies \[]:
    -   @apollo/federation-internals@2.8.3-beta.1
    -   @apollo/query-graphs@2.8.3-beta.1

## @apollo/gateway@2.8.3-beta.1

### Patch Changes

- Updated dependencies
\[[`f376447a820e3c0ae41d16d1fd3b681d2f1e8c14`](f376447)]:
    -   @apollo/composition@2.8.3-beta.1
    -   @apollo/federation-internals@2.8.3-beta.1
    -   @apollo/query-planner@2.8.3-beta.1

## @apollo/query-graphs@2.8.3-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @apollo/federation-internals@2.8.3-beta.1

## @apollo/query-planner@2.8.3-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @apollo/federation-internals@2.8.3-beta.1
    -   @apollo/query-graphs@2.8.3-beta.1

## @apollo/subgraph@2.8.3-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @apollo/federation-internals@2.8.3-beta.1

## @apollo/federation-internals@2.8.3-beta.1



## apollo-federation-integration-testsuite@2.8.3-beta.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to
version-2.8.3-beta, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-2.8.3-beta` is currently in **pre mode** so this branch has
prereleases rather than normal releases. If you want to exit
prereleases, run `changeset pre exit` on `version-2.8.3-beta`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @apollo/composition@2.8.3-beta.2

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c)]:
    -   @apollo/federation-internals@2.8.3-beta.2
    -   @apollo/query-graphs@2.8.3-beta.2

## @apollo/gateway@2.8.3-beta.2

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c)]:
    -   @apollo/federation-internals@2.8.3-beta.2
    -   @apollo/composition@2.8.3-beta.2
    -   @apollo/query-planner@2.8.3-beta.2

## @apollo/federation-internals@2.8.3-beta.2

### Patch Changes

- dummy commit to force beta.2
([#3078](#3078))

## @apollo/query-graphs@2.8.3-beta.2

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c)]:
    -   @apollo/federation-internals@2.8.3-beta.2

## @apollo/query-planner@2.8.3-beta.2

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c)]:
    -   @apollo/federation-internals@2.8.3-beta.2
    -   @apollo/query-graphs@2.8.3-beta.2

## @apollo/subgraph@2.8.3-beta.2

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c)]:
    -   @apollo/federation-internals@2.8.3-beta.2

## apollo-federation-integration-testsuite@2.8.3-beta.2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Meschreiber and others added 20 commits July 11, 2024 16:35
Updates federation quickstart to align with new Studio UI
Adding a short announcement one-liner to bring visibility to GraphQL
Summit
Add quickstart redirect
Update `main` with `version-2.8.3-beta`
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/composition@2.8.3

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Add a fast path to skip override validation for fields without any
subgraph `@override`s.
([#3070](#3070))

- Type merging now uses maps instead of sparsely-populated arrays for
per-subgraph data.
([#3069](#3069))

- Stop duplicating hints for inconsistent value type fields per
subgraph.
([#3071](#3071))

- Fix logic to compute missing subgraphs when generating composition
hints/errors
([#3076](#3076))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3
    -   @apollo/federation-internals@2.8.3

## @apollo/gateway@2.8.3

### Patch Changes

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`67b70c6e68b1cdbf8f03dacafd636e27ed9b7814`](67b70c6),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`f5f6a799d6b3675eecb0eaec7a816d746cd136b2`](f5f6a79),
[`42bd27af6a23bcfdd36951dbfa3fb9f7ba833f3a`](42bd27a),
[`f376447a820e3c0ae41d16d1fd3b681d2f1e8c14`](f376447),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/composition@2.8.3
    -   @apollo/federation-internals@2.8.3
    -   @apollo/query-planner@2.8.3

## @apollo/federation-internals@2.8.3

### Patch Changes

- dummy commit to force beta.2
([#3078](#3078))

- For very large graphs cloning types with lots of join directives can
be expensive. Since these directives will not be used in the Schema that
is cloned for toAPISchema(), add the ability to optionally omit them
([#3053](#3053))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

## @apollo/query-graphs@2.8.3

### Patch Changes

- Error messages are now lazily evaluated for satisfiability
validations.
([#3068](#3068))

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3

## @apollo/query-planner@2.8.3

### Patch Changes

- Query graph caches now use maps instead of sparsely-populated arrays
for per-subgraph data.
([#3066](#3066))

- Use sets instead of arrays for tracking schema type/directive
referencers.
([#3067](#3067))

- Updated dependencies
\[[`38debcf2f9af1a719bd1c8acbd9335efa8427ddb`](38debcf),
[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`860aace9904e787f9bf05aad94be5b5920f10543`](860aace),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/query-graphs@2.8.3
    -   @apollo/federation-internals@2.8.3

## @apollo/subgraph@2.8.3

### Patch Changes

- Updated dependencies
\[[`50d648ccffb05591878de75dc5522914ed48698f`](50d648c),
[`f753d55e9a49d11389ee4f8d7976533447e95ede`](f753d55),
[`3af790517d662f3bec9064c0bf243014c579e9cd`](3af7905)]:
    -   @apollo/federation-internals@2.8.3

## apollo-federation-integration-testsuite@2.8.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The idea is to make SchemaUpgrader faster by precomputing each type into
a map that can be passed around once rather. Ideally we would be able to
entirely get rid of `otherSubgraphs` as a parameter to SchemaUpgrader
before this PR is ready.

Note that although this works with tests, I think there may be an issue
with interfaces that isn't covered by tests, so do not merge unless
someone has a chance to look at this with a critical eye. (I think the
issue is that the map is built by iterating over `objectTypes` but later
code iterates over `types()` which may include interfaces.
Renaming page in order to avoid any confusion on what subgraph
implementations are actually supported by Apollo.
Add redirect for subgraph compatibility page
)

This PR :
- Restructures the very lengthy
https://www.apollographql.com/docs/federation/entities-advanced into
multiple pages for each use case described
- Renames the "federated-types" directory -> "federated-schemas" (this
is already what it's called in the Federation docs nav, the URLs just
don't match)
Fixes broken links + adds a redirect
Rather than relying on the fact that one filteredPaths is reached, allow
@interfaceObject types to intersect with all runtime types
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
…ing (#3094)

It could be valid to have two fields of the same that are not shareable
if one of them is being overridden. Don't add @sharable to subscription
fields and just let it be a composition error if neither are overrides.
As @Shareable is not allowed on a subscription field, they should never
exist there in any case.
Took the text from our docs

https://www.apollographql.com/docs/federation/federated-schemas/federated-directives/#override
<!--
First, 🌠 thank you 🌠 for taking the time to consider a contribution to
Apollo!

Here are some important details to follow:

* ⏰ Your time is important
To save your precious time, if the contribution you are making will
take more than an hour, please make sure it has been discussed in an
        issue first. This is especially true for feature requests!

* 💡 Features
Feature requests can be created and discussed within a GitHub Issue.
Be sure to search for existing feature requests (and related issues!)
prior to opening a new request. If an existing issue covers the need,
please upvote that issue by using the 👍 emote, rather than opening a
        new issue.

* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a
bug,
please _try_ to add a test which verifies the fix. If you cannot, you
should
still submit the PR but we may still ask you (and help you!) to create a
test.

* Federation versions
Please make sure you're targeting the federation version you're opening
the PR for. Federation 2 (alpha) is currently located on the `main`
branch and prior versions of Federation live on the `version-0.x`
branch.

* 📖 Contribution guidelines
Follow
https://github.com/apollographql/federation/blob/HEAD/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and
add
        tests for all new behavior.

* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what
        your pull request is meant to accomplish. Provide 🔗 links 🔗 to
        associated issues!

We hope you will find this to be a positive experience! Open source
contribution can be intimidating and we hope to alleviate that pain as
much
as possible. Without following these guidelines, you may be missing
context
that can help you succeed with your contribution, which is why we
encourage
discussion first. Ultimately, there is no guarantee that we will be able
to
merge your pull-request, but by following these guidelines we can try to
avoid disappointment.

-->
Hello 👋 

While reading the docs on Apollo Federation, I found following issues:
1. This page contains invalid link:
https://www.apollographql.com/docs/federation/federated-schemas/federated-directives/#override
Old link leads to this URL, which gives 404:
https://www.apollographql.com/docs/federation/entities/migrating-fields
A correct link was already used on this page (`/migrate-fields`), I used
it for the fix.

2. This page has broken link:
https://www.apollographql.com/docs/federation/entities/
<img width="929" alt="Screenshot 2024-07-25 at 14 04 22"
src="https://github.com/user-attachments/assets/f16a9cc2-9be8-4e2d-8f32-cae50a99875c">

3. This page has broken links to /define-keys:
https://www.apollographql.com/docs/federation/entities/
e.g.
https://www.apollographql.com/docs/federation/entities/define-keys/#multiple-keys
-> 404
This PR is for a very minor grammatical correction in the docs verbiage.

<!--
First, 🌠 thank you 🌠 for taking the time to consider a contribution to
Apollo!

Here are some important details to follow:

* ⏰ Your time is important
To save your precious time, if the contribution you are making will
take more than an hour, please make sure it has been discussed in an
        issue first. This is especially true for feature requests!

* 💡 Features
Feature requests can be created and discussed within a GitHub Issue.
Be sure to search for existing feature requests (and related issues!)
prior to opening a new request. If an existing issue covers the need,
please upvote that issue by using the 👍 emote, rather than opening a
        new issue.

* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a
bug,
please _try_ to add a test which verifies the fix. If you cannot, you
should
still submit the PR but we may still ask you (and help you!) to create a
test.

* Federation versions
Please make sure you're targeting the federation version you're opening
the PR for. Federation 2 (alpha) is currently located on the `main`
branch and prior versions of Federation live on the `version-0.x`
branch.

* 📖 Contribution guidelines
Follow
https://github.com/apollographql/federation/blob/HEAD/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and
add
        tests for all new behavior.

* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what
        your pull request is meant to accomplish. Provide 🔗 links 🔗 to
        associated issues!

We hope you will find this to be a positive experience! Open source
contribution can be intimidating and we hope to alleviate that pain as
much
as possible. Without following these guidelines, you may be missing
context
that can help you succeed with your contribution, which is why we
encourage
discussion first. Ultimately, there is no guarantee that we will be able
to
merge your pull-request, but by following these guidelines we can try to
avoid disappointment.

-->
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/composition@2.8.4

### Patch Changes

- When doing interface type intersection detection, allow
@interfaceObject to stand in for any type
([#3087](#3087))

- Updated dependencies
\[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16),
[`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]:
    -   @apollo/federation-internals@2.8.4
    -   @apollo/query-graphs@2.8.4

## @apollo/gateway@2.8.4

### Patch Changes

- Updated dependencies
\[[`4d9e0f6390c5114132d205ab73b6aa1b9ffa8cd8`](4d9e0f6),
[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16),
[`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]:
    -   @apollo/composition@2.8.4
    -   @apollo/federation-internals@2.8.4
    -   @apollo/query-planner@2.8.4

## @apollo/federation-internals@2.8.4

### Patch Changes

- When auto-upgrading schemas from fed1, never add @Shareable on
subscription fields.
([#3094](#3094))

- Save time in SchemaUpgrader by pre-computing which subgraphs contain
each type
([#3057](#3057))

## @apollo/query-graphs@2.8.4

### Patch Changes

- Updated dependencies
\[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16),
[`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]:
    -   @apollo/federation-internals@2.8.4

## @apollo/query-planner@2.8.4

### Patch Changes

- Updated dependencies
\[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16),
[`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]:
    -   @apollo/federation-internals@2.8.4
    -   @apollo/query-graphs@2.8.4

## @apollo/subgraph@2.8.4

### Patch Changes

- Add descriptions for federation directives
([#3095](#3095))

- Updated dependencies
\[[`5f4bb160d024678d6facd471c43c8ec61c86e701`](5f4bb16),
[`672aca7cbeb0a6a38586357a4e154f2dd91caa0c`](672aca7)]:
    -   @apollo/federation-internals@2.8.4

## apollo-federation-integration-testsuite@2.8.4

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copyedit Quickstart's title, subtitle, and initial paragraph to
introduce GraphOS and supergraph
@dylan-apollo dylan-apollo requested review from a team as code owners August 6, 2024 17:26
Copy link

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: cae9be3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit cae9be3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/66b25cc73af31c0008d1d940
😎 Deploy Preview https://deploy-preview-3107--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Aug 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sachindshinde sachindshinde merged commit 2f4f0dd into next Aug 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.