Fix usage of Appsignal::Logger#tagged with several tags
#1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `.tagged` on our logger directly (without wrapping it in `ActiveSupport::TaggedLogging`) we should support passing tags as separate arguments, like newer versions of Rails do.
unflxw
force-pushed
the
fix-tagged-several-tags
branch
from
ae7527e to
c8b35ee
Compare
unflxw
added a commit
that referenced
this pull request
Dec 19, 2024
This commit removes tagged logging support from `Appsignal::Logger`, essentially reverting most of the changes in #1344, #1350, #1351 and The change to use instance variables instead of thread variables is maintained, as well as the tests that assert the expected behaviour when used alongside `ActiveSupport::TaggedLogging`, which pass notwithstanding the reverted functionality. This makes explicit in our test suite the way in which tagged logging is supported.
unflxw
added a commit
that referenced
this pull request
Dec 30, 2024
When a formatter is set for the broadcast logger, also set that same formatter for all the loggers that it broadcasts to. Before this change, the already-formatted message would be passed on to the broadcasted loggers, which would format it once again. This issue was masked by the tests matching the resulting log line using `a_string_starting_with`, which I introduced in #1351 to smooth out differences between our custom instrumentation of tagged logging, since removed, and that of `ActiveSupport::TaggedLogging`. Ensure all matching is done against specific strings. Fixes issue #1360, in which the twice-applied formatting causes additional newlines to appear in the message emitted by the broadcasted loggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
.taggedon our logger directly (without wrapping it inActiveSupport::TaggedLogging) we should support passing tags as separate arguments, like newer versions of Rails do.This should actually fix #1349, as well as this issue encountered by our GoodJob test setup.