Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(image): return error early if total size of layers exceeds limit #8294

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat(image): return error early if total size of layers exceeds limit #8294

wants to merge 13 commits into from

Conversation

nikpivkin
Copy link
Contributor

Description

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

nikpivkin and others added 13 commits December 25, 2024 21:38
@nikpivkin
feat(image): prevent scanning oversized container images
84689dd 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
refactor: pull layers in parallel
eddcbf8 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
refactor: clear an error when image size is exceeded
2902779 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
test: add tests for image flags
adaea74 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
test: add integration tests
a6ce2ed 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
refactor: remove cached layers in clean
bba405b 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
feat(image): check compressed size
db8e61c 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
refactor: use log for logging error on exit
e3a827b 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@knqyf263
chore: add debug messages
ec124bd 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@nikpivkin
refactor: remove cached layers after inspect image
7cd0a27 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
chore(cli): mark max-image-size as experimental
9c46e08 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
add usage docs
d3f5083 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin
feat(image): return error early if total size of layers exceeds limit
4a02730 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 will be requested when the pull request is marked ready for review knqyf263 is a code owner

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen will be requested when the pull request is marked ready for review DmitriyLewen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @knqyf263