feat: remove bufferAlgorithm param from the open command
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
+ Coverage 20.14% 20.84% +0.69%
==========================================
Files 42 40 -2
Lines 3222 3114 -108
==========================================
Hits 649 649
+ Misses 2488 2380 -108
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
per1234
added
type: enhancement
dido18
changed the title
bufferAlgorithm params in the open commandbufferAlgorithm params in the open command
dido18
force-pushed
the
remove-open-not-used-buffer-algorithm
branch
from
d3ec8c8 to
679a319
Compare
dido18
force-pushed
the
remove-open-not-used-buffer-algorithm
branch
from
786ac2b to
98b6376
Compare
|
TODO
|
dido18
changed the title
bufferAlgorithm params in the open commandbufferAlgorithm params
dido18
changed the title
bufferAlgorithm params bufferAlgorithm param
cmaglie
approved these changes
Jan 13, 2025
Co-authored-by: Cristian Maglie <c.maglie@arduino.cc>
|
Tested on Windows with an Arduino UNO r4. Everything works as expected 🚀 |
cmaglie
requested changes
Jan 15, 2025
cmaglie
approved these changes
Jan 20, 2025
dido18
force-pushed
the
remove-open-not-used-buffer-algorithm
branch
from
9d2b0ab to
43bd6ea
Compare
dido18
changed the title
bufferAlgorithm parambufferAlgorithm param from the open command
dido18
changed the title
bufferAlgorithm param from the open commandbufferAlgorithm param from the open command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Remove the
bufferAlgorithmargument from theopencommand.Reasons: the Arduino projects use only the
timedalgorithm. No need for the other two options.timedoption.timedoption.The open command accepts 3 different
bufferAlgorithm.open <portName> <baud> [bufferAlgorithm: ({default}, timed, timedraw)]The
bufferAlgorithmargument is removed and it not possible to set the algorithm (the timed is always used)open <portName> <baud>.If the argument is specified, the following warn log is printed: