Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM Synthesis code that could be combined with imaging one day #262

Open
wants to merge 23 commits into
base: development
Choose a base branch
from

Conversation

Luke-Pratley
Copy link
Collaborator

@Luke-Pratley Luke-Pratley commented May 13, 2019

RM measurement operator + example of 1d reconstruction + tests

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #262 into development will increase coverage by 0.44%.
The diff coverage is 93.29%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #262      +/-   ##
===============================================
+ Coverage        86.46%   86.91%   +0.44%     
===============================================
  Files               66       70       +4     
  Lines             6259     6602     +343     
===============================================
+ Hits              5412     5738     +326     
- Misses             847      864      +17
Impacted Files Coverage Δ
cpp/tests/rm_operator.cc 100% <100%> (ø)
cpp/purify/rm_kernel_integration.cc 100% <100%> (ø)
cpp/purify/rm_operators.cc 70% <70%> (ø)
cpp/purify/rm_operators.h 95.53% <95.53%> (ø)
cpp/purify/kernels.cc 61.17% <0%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a732220...5f5189a. Read the comment docs.

@Luke-Pratley
Copy link
Collaborator Author

This is ready to merge!

@CosmoMatt
Copy link
Collaborator

hey @Luke-Pratley we're tidying up PR's for PURIFY, can you remember what the state of this PR is? It seems as though it's ready to go, provided a few conflicts?

@Luke-Pratley
Copy link
Collaborator Author

@CosmoMatt I think it is fine for it to be merged tbh. It is adjacent to the interferometric imaging, so I am not surprised it is mostly ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants