Remove Loop::execute scoping #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using `Loop::run();` instead of putting the entire application into a closure. A default loop can be setup using Composer's `"files"` autoload feature. Scoping can be implemented on top by testing frameworks or other libraries. Closes #148.
sagebind
reviewed
Mar 9, 2017
| } | ||
|
|
||
| return $driver; | ||
| $driver = self::$driver ?: self::get(); |
There was a problem hiding this comment.
What is the purpose of this get() call if it just returns the value of $driver?
|
Closing, as project discontinued for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using
Loop::run();instead of putting the entireapplication into a closure. A default loop can be setup using Composer's
"files"autoload feature. Scoping can be implemented on top by testingframeworks or other libraries.
Closes #148.