This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update php.cson to detect SQL CTEs #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL "common table expressions" (CTE) begin with the `WITH` keyword. More info: https://docs.microsoft.com/en-us/sql/t-sql/queries/with-common-table-expression-transact-sql?view=sql-server-ver15#examples
KapitanOczywisty
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
There is slight possibility for false-positives, but shouldn't be too serious.
https://grep.app/search?q=%5B%27%22%5DWITH%5Cs®exp=true&case=true&filter[lang][0]=PHP
|
Yeah, stuff like #418 is generally inevitable without complicating the pattern. It's a tradeoff most of us are okay with I think |
sadick254
approved these changes
May 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Update
php.csonto detect SQL CTEs by making it detect"WITH ... "(both single and double quoted) as an SQL string.SQL "common table expressions" (CTE) begin with the
WITHkeyword. More info:https://docs.microsoft.com/en-us/sql/t-sql/queries/with-common-table-expression-transact-sql?view=sql-server-ver15#examples
Benefits
CTEs are syntax highlighted. Currently they are not, but they are still valid SQL.
Possible Drawbacks
NoneSee #418