Skip to content

Commit

Permalink
fix typo
Browse files Browse the repository at this point in the history
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
  • Loading branch information
oguzkaganozt committed Jan 30, 2025
1 parent eb43954 commit 64ca686
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 35 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-and-push-arm64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
# uses: ./.github/actions/docker-build-and-push-tools
# with:
# platform: arm64
# target-image: autoware
# target-image: autoware-tools
# build-args: |
# *.platform=linux/arm64
# *.args.ROS_DISTRO=${{ needs.load-env.outputs.rosdistro }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-and-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
uses: ./.github/actions/docker-build-and-push-tools
with:
platform: amd64
target-image: autoware
target-image: autoware-tools
build-args: |
*.platform=linux/amd64
*.args.ROS_DISTRO=${{ needs.load-env.outputs.rosdistro }}
Expand Down
14 changes: 7 additions & 7 deletions docker/tools/Dockerfile.simulator
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ RUN chmod +x /autoware/resolve_rosdep_keys.sh
# Install dependencies and build the simulator
RUN --mount=type=ssh \
--mount=type=cache,target=/var/cache/apt,sharing=locked \
&& apt-get update \
apt-get update \
&& rosdep update && rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO \
&& source /opt/ros/"$ROS_DISTRO"/setup.bash && source /opt/autoware/setup.bash \
&& colcon build --cmake-args \
"-Wno-dev" \
"--no-warn-unused-cli" \
--install-base /opt/autoware \
--merge-install \
--mixin release compile-commands ccache \
--base-paths /autoware/src/simulator \
"-Wno-dev" \
"--no-warn-unused-cli" \
--install-base /opt/autoware \
--merge-install \
--mixin release compile-commands ccache \
--base-paths /autoware/src/simulator \
&& find /opt/autoware/lib -type f -name "*.py" -exec chmod +x {} \; \
&& find /opt/autoware/share -type f -name "*.py" -exec chmod +x {} \; \
&& apt-get clean \
Expand Down
52 changes: 26 additions & 26 deletions docker/tools/Dockerfile.visualizer
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@ RUN chmod +x /autoware/resolve_rosdep_keys.sh

# Build simulator messages and rviz plugins ONLY
RUN --mount=type=ssh \
--mount=type=cache,target=/var/cache/apt,sharing=locked \
&& apt-get update \
&& source /opt/ros/"$ROS_DISTRO"/setup.bash && source /opt/autoware/setup.bash \
&& rosdep update && rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO \
&& colcon build --cmake-args \
"-Wno-dev" \
"--no-warn-unused-cli" \
--install-base /opt/autoware \
--merge-install \
--mixin release compile-commands ccache \
--base-paths /autoware/src \
--packages-up-to-regex ".*_msgs$" ".*rviz_plugin$" \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* "$HOME"/.cache
--mount=type=cache,target=/var/cache/apt,sharing=locked \
apt-get update \
&& source /opt/ros/"$ROS_DISTRO"/setup.bash && source /opt/autoware/setup.bash \
&& rosdep update && rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO \
&& colcon build --cmake-args \
"-Wno-dev" \
"--no-warn-unused-cli" \
--install-base /opt/autoware \
--merge-install \
--mixin release compile-commands ccache \
--base-paths /autoware/src \
--packages-up-to-regex ".*_msgs$" ".*rviz_plugin$" \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* "$HOME"/.cache

# Extract rosdep dependencies for visualizer
RUN source /opt/ros/"$ROS_DISTRO"/setup.bash && source /opt/autoware/setup.bash \
Expand All @@ -48,18 +48,18 @@ COPY --from=builder /rosdep-visualizer-depend-packages.txt /tmp/rosdep-visualize

# Install openbox, VNC, ngrok, and simulator dependencies

Check warning on line 49 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (openbox)

Check warning on line 49 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ngrok)
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
curl unzip openbox tigervnc-standalone-server tigervnc-common \
novnc websockify python3-numpy python3-xdg \
&& curl -sSL https://ngrok-agent.s3.amazonaws.com/ngrok.asc \
| tee /etc/apt/trusted.gpg.d/ngrok.asc >/dev/null && \
echo "deb https://ngrok-agent.s3.amazonaws.com buster main" \
| tee /etc/apt/sources.list.d/ngrok.list && \
apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y ngrok \
# Remove xmlschema and yamale from rosdep packages since we install via pip
&& sed -i '/\(xmlschema\|yamale\)/d' /tmp/rosdep-visualizer-depend-packages.txt \
&& pip install yamale xmlschema \
&& cat /tmp/rosdep-visualizer-depend-packages.txt | xargs apt-get install -y --no-install-recommends \
&& /autoware/cleanup_system.sh $LIB_DIR $ROS_DISTRO
curl unzip openbox tigervnc-standalone-server tigervnc-common \

Check warning on line 51 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (openbox)

Check warning on line 51 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (tigervnc)

Check warning on line 51 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (tigervnc)
novnc websockify python3-numpy python3-xdg \

Check warning on line 52 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (novnc)

Check warning on line 52 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (websockify)
&& curl -sSL https://ngrok-agent.s3.amazonaws.com/ngrok.asc \
| tee /etc/apt/trusted.gpg.d/ngrok.asc >/dev/null \

Check warning on line 54 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ngrok)
&& echo "deb https://ngrok-agent.s3.amazonaws.com buster main" \
| tee /etc/apt/sources.list.d/ngrok.list \

Check warning on line 56 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ngrok)
&& apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y ngrok \

Check warning on line 57 in docker/tools/Dockerfile.visualizer

View workflow job for this annotation

GitHub Actions / spell-check-differential

Unknown word (ngrok)
# Remove xmlschema and yamale from rosdep packages since we install via pip
&& sed -i '/\(xmlschema\|yamale\)/d' /tmp/rosdep-visualizer-depend-packages.txt \
&& pip install yamale xmlschema \
&& cat /tmp/rosdep-visualizer-depend-packages.txt | xargs apt-get install -y --no-install-recommends \
&& /autoware/cleanup_system.sh $LIB_DIR $ROS_DISTRO

# Set up VNC password
RUN mkdir -p ~/.vnc && \
Expand Down

0 comments on commit 64ca686

Please sign in to comment.