feat: efm2 #371
Open
feat: efm2 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyc-bq
force-pushed
the
efm2
branch
3 times, most recently
from
765f928 to
cec0010
Compare
sophia-bq
reviewed
Jan 24, 2025
| } | ||
|
|
||
| private throwUnableToIdentifyConnection(host: HostInfo | null, provider: HostListProvider | null): never { | ||
| throw new AwsWrapperError( |
There was a problem hiding this comment.
Can you include the call to this.pluginService.getHostListProvider() in here? Seems like you don't need to pass through a provider
|
|
||
| try { | ||
| if (rdsUrlType.isRdsCluster) { | ||
| logger.debug("Monitoring host info is associated with a cluster endpoint, plugin needs to identify the cluster connection"); |
There was a problem hiding this comment.
Add to en.json
Suggested change
| logger.debug("Monitoring host info is associated with a cluster endpoint, plugin needs to identify the cluster connection"); | |
| logger.debug("Monitoring host info is associated with a cluster endpoint, plugin needs to identify the cluster connection."); |
| return this.monitoringHostInfo; | ||
| } | ||
|
|
||
| async notifyConnectionChanged(changes: Set<HostChangeOptions>): Promise<OldConnectionSuggestionAction> { |
There was a problem hiding this comment.
No other implementation of notifyConnectionChanged potentially returns nothing - what happens in the case it does not return OldConnectionSuggestionAction.NO_OPINION?
| context.setInactive(); | ||
| try { | ||
| await clientToAbort.abort(); | ||
| await clientToAbort.end(); |
There was a problem hiding this comment.
Have we tried one or the other on the most recent version?
| this.abortedConnectionsCounter.inc(); | ||
| } catch (error) { | ||
| // ignore | ||
| logger.debug(Messages.get("MonitorConnectionContext.exceptionAbortingConnection", error.message)); |
There was a problem hiding this comment.
Message should use error instead of exception
Suggested change
| logger.debug(Messages.get("MonitorConnectionContext.exceptionAbortingConnection", error.message)); | |
| logger.debug(Messages.get("MonitorConnectionContext.errorAbortingConnection", error.message)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.