Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): mpl head step for rust #1583

Merged
merged 1 commit into from
Jan 21, 2025
Merged

chore(CI): mpl head step for rust #1583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/library_rust_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ on:
required: false
default: false
type: boolean
mpl-head:
description: "Running on MPL HEAD"
required: false
default: false
type: boolean

jobs:
testRust:
Expand Down Expand Up @@ -59,6 +64,15 @@ jobs:
with:
dafny-version: nightly-2024-12-03-4954170

- name: Update MPL submodule if using MPL HEAD
if: ${{ inputs.mpl-head == true }}
working-directory: submodules/MaterialProviders
run: |
git checkout main
git pull
git submodule update --init --recursive
git rev-parse HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why do we need this? Is this to log current commit hash in CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you do the normal submodule checkout in the set up above that only checks out the commit that is being tracked by the repo.
by going into the submodule and checking out the latest explicitly we make sure we pull all the latest changes including submodule changes within the mpl.
the git rev-parse HEAD is a stdout message for us to visually check it is the latest.


# Remove this after the formatting in Rust starts working
- name: smithy-dafny Rust hacks
shell: bash
Expand Down
Loading