Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook as iso to our builds #4256

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

rahulbabu95
Copy link
Member

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2663

Description of changes:

Upstream Hook, now supports ISO builds which is required to boot the hardware with just L3 connectivity to the baremetal instance. Hook as ISO also supports IPAM config such as staic IPAM. Bump Hook to the latest version and enable building Hook as ISO in our tooling. One thing to note is Linuxkit sources a bunch of base images from their registry to build the actual os Image. In our tooling, we typically override those targets to source the image from our public registry. Patch Linuxkit to be able to do that for iso builds. Also, in the latest Hook version, hook-ip images aren't shipped as they are no longer needed. Remove Hook-Ip image builds from the Hook project builds.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2025
@rahulbabu95 rahulbabu95 force-pushed the l3/hook-iso branch 3 times, most recently from a598294 to e9fdb3d Compare January 24, 2025 02:54
projects/tinkerbell/hook/Makefile Outdated Show resolved Hide resolved
projects/tinkerbell/hook/Makefile Outdated Show resolved Hide resolved
Upstream Hook, now supports ISO builds which is required to boot the
hardware with just L3 connectivity to the baremetal instance. Hook as
ISO also supports IPAM config such as staic IPAM. Bump Hook to the
latest version and enable building Hook as ISO in our tooling. One thing
to note is Linuxkit sources a bunch of base images from their registry to
build the actual os Image. In our tooling, we typically override those
targets to source the image from our public registry. Patch Linuxkit
to be able to do that for iso builds. Also, in the latest Hook version,
hook-ip images aren't shipped as they are no longer needed. Remove Hook-Ip
image builds from the Hook project builds.

Signed-off-by: Rahul Ganesh <rahulbabu95@gmail.com>
@rahulbabu95
Copy link
Member Author

/override hook-tooling-presubmit-arm64

@eks-distro-bot
Copy link
Collaborator

@rahulbabu95: Overrode contexts on behalf of rahulbabu95: hook-tooling-presubmit-arm64

In response to this:

/override hook-tooling-presubmit-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rahulbabu95
Copy link
Member Author

/override hook-tooling-presubmit-amd64

@eks-distro-bot
Copy link
Collaborator

@rahulbabu95: Overrode contexts on behalf of rahulbabu95: hook-tooling-presubmit-amd64

In response to this:

/override hook-tooling-presubmit-amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit e4dc6de into aws:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants