Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test image and close file #19

Merged
merged 1 commit into from
Sep 10, 2024
+7 −7
Merged

Update test image and close file #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/basic-job-example-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ hydra:

training_cfg:
# entry_script: Required. Path to the entry script of training/fine-tuning, this path should be inside container
entry_script: ./train.py
entry_script: /opt/pytorch-mnist/mnist.py
# script_args: Optional. List of script arguments. Example of usage:
# script_args:
# - --max_context_width: 4096
Expand Down Expand Up @@ -90,7 +90,7 @@ cluster:
# base_results_dir: Optional. Location to store the results, checkpoints and logs.
base_results_dir: ./result
# container: Required. Docker image to be used for Training Job
container: docker.io/kubeflowkatib/pytorch-mnist:v1beta1-45c5727
container: docker.io/kubeflowkatib/pytorch-mnist-cpu:v1beta1-bc09cfd

# env_vars: Optional. Environment variables passed to the training job.
env_vars:
Expand Down
6 changes: 3 additions & 3 deletions src/hyperpod_cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ def store_current_hyperpod_context(data):


def _retrieve_current_hyperpod_context():
file = open(
with open(
GENERATED_LAUNCHER_CONFIG_FILE_PATH + HYPERPOD_CLUSTER_CONTEXT_FILE_NAME,
"r",
)
return json.load(file)
) as file:
return json.load(file)


def _validate_link(console_url):
Expand Down
4 changes: 2 additions & 2 deletions test/integration_tests/data/basicJob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ hydra:
output_subdir: null

training_cfg:
entry_script: ./train.py
entry_script: /opt/pytorch-mnist/mnist.py
script_args: []
run:
name: hyperpod-cli-test # Current run name
Expand Down Expand Up @@ -49,7 +49,7 @@ cluster:
restartPolicy: OnFailure # restart policy

base_results_dir: ./result # Location to store the results, checkpoints and logs.
container: docker.io/kubeflowkatib/pytorch-mnist:v1beta1-45c5727 # container to use
container: docker.io/kubeflowkatib/pytorch-mnist-cpu:v1beta1-bc09cfd # container to use

env_vars:
NCCL_DEBUG: INFO # Logging level for NCCL. Set to "INFO" for debug information
Loading