Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config::from_env never returns an error. #754

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Config::from_env never returns an error. #754

merged 1 commit into from
Dec 16, 2023

Conversation

calavera
Copy link
Contributor

Description of changes:

We don't need to return Result because the function either panics or returns the Ok value.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@calavera
Config::from_env never returns an error.
4b0fb9e 
We don't need to return Result because the function either panics or returns the Ok value.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera calavera requested a review from bnusunny December 15, 2023 23:20
@calavera calavera merged commit fb86ebc into main Dec 16, 2023
7 checks passed
@calavera calavera deleted the config_result branch December 16, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenwoodcm greenwoodcm greenwoodcm approved these changes

@bnusunny bnusunny Awaiting requested review from bnusunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calavera @greenwoodcm