Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add semconv_experimental flag #943

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Nov 18, 2024

✍️ Description of changes:

Fix import of FAAS_COLDSTART, FAAS_TRIGGER and FAAS_INVOCATION_ID which are now behind a feature flag (see: https://docs.rs/opentelemetry-semantic-conventions/0.27.0/src/opentelemetry_semantic_conventions/trace.rs.html#229)

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxday maxday merged commit 3f18eec into dependabot/cargo/opentelemetry-semantic-conventions-0.27 Nov 19, 2024
10 checks passed
@maxday maxday deleted the maxday/fix-bump-opentelemetry-semantic-conventions branch November 19, 2024 09:01
maxday added a commit that referenced this pull request Nov 19, 2024
…27 (#942)

* Update opentelemetry-semantic-conventions requirement from 0.14 to 0.27

Updates the requirements on [opentelemetry-semantic-conventions](https://github.com/open-telemetry/opentelemetry-rust) to permit the latest version.
- [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases)
- [Commits](open-telemetry/opentelemetry-rust@opentelemetry-semantic-conventions-0.14.0...opentelemetry-semantic-conventions-0.27.0)

---
updated-dependencies:
- dependency-name: opentelemetry-semantic-conventions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: add semconv_experimental flag (#943)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maxime David <maxday@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants