Improve exception handling #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hot pulling and integrated them
technoir42
reviewed
Dec 15, 2023
| @@ -174,14 +175,17 @@ class Marathon( | |||
| try { | |||
| scheduler.stopAndWaitForCompletion() | |||
| onFinish(analytics, deviceProvider, attachmentManager) | |||
| } catch (up: ReportGenerationException) { | |||
| // We don't want to catch this. This should fail the execution | |||
| throw up | |||
There was a problem hiding this comment.
Have you considered doing the same for all Throwables?
There was a problem hiding this comment.
I couldn't test many other exceptions so I'm not sure how often this will happen.
I updated it so that now, we do the same for all throwables, but we need to monitor the results carefully, in case something unexpected breaks
technoir42
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom exceptions for failures in report generation and screenshot pulling and integrated them