spot-termination-exporter: Add priority class name spot termination exporter #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the |
Add new 'priorityClassName' option to allow users to set their own priority to the spot-termination-expoter pods.
This fixes the following problem with 'helm lint --strict': ==> Linting spot-termination-exporter/ [INFO] Chart.yaml: icon is recommended [ERROR] templates/: render error in "spot-termination-exporter/templates/service.yaml": template: spot-termination-exporter/templates/_helpers.tpl:14:40: executing "spotTerminationexporter.fullname" at <.Values.nameOverride>: map has no entry for key "nameOverride"
Add appVersion field to Helm can display the version of the app that's deployed when using 'helm list' and similar commands.
hwoarang
force-pushed
the
add-priority-class-name-spot-termination-exporter
branch
from
63cdc8c to
d02e780
Compare
ahma
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This pull request allows users to set priorityClassName to spot-termination-exporter pods. It also fixes a couple of other minor issues in the helm chart itself.
Why?
There are cases were having spot-termination-exporter pods being able to schedule on every node is critical for the monitoring of the cluster. As such, we should be using priorities in that case to make sure that the DS always take precedence against other lower priority workloads.
Additional context
A couple of other fixes related to helm lint and also to the Chart itself.
Checklist