Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simplify SetGasLimit contract, fixing rollback nonce #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Simplify SetGasLimit contract, fixing rollback nonce #122

wants to merge 1 commit into from

Conversation

BrianBland
Copy link
Contributor

Removes the UpgradeGasLimit and RollbackGasLimit contracts, standardizing on just the shared SetGasLimit. This requires callers to specify FROM_GAS_LIMIT and TO_GAS_LIMIT, but ensures that the getNonce method is not overridden.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 29, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x00101010 0x00101010 0x00101010 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrianBland @cb-heimdall @0x00101010