Fixup az post ttb and develop merge #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,6 +46,8 @@ deserialize({error, {Code, Message}}) when is_integer(Code), is_atom(Message) -> | |||
| {error, {Code, iolist_to_binary(atom_to_list(Message))}}; | |||
| deserialize({error, Message}) -> | |||
| {error, Message}; | |||
| deserialize(tsgetresp) -> | |||
| {ok, {[], []}}; | |||
There was a problem hiding this comment.
Indeed. Sorry I didn't see your PR in time (it had taken me a good hour to arrive at the same conclusion).
|
Testing manually works fine. Build errors: |
|
But you need basho/riak_pb#190 (that is, the branch in it). |
|
That's from buildbot, not my machine. Too bad we don't have a better way to specify deps. Anyway, +1 e8272aa |
hmmr
force-pushed
the
fixup-az-post_ttb_and_develop_merge
branch
from
e8272aa to
bff6899
Compare
|
👍 bff6899 |
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to basho/riak_kv#1382, requires basho/riak_pb#190.
Contains a fix for the case of
riakc_ts:getreturning an empty set, where the client connection is broken with an error message implicating 'tsgetresp'.Also, properly decode the error message of
get_coverage(previously, this was done in riak_kv_ts_svc, which is not the right place for assembling#ts...records since this module now serves PB as well as TTB messages).