new module ts_http_api_SUITE

[hmmr]

RTS-258

Originally by @lehoff (submitted in #1015), with modifications per changes and fixes in basho/riak_kv#1398, now resubmitted against proper branch.

[hmmr]

Now with additional commits with changes to account for a regression in basho/riak_kv#1378, and changes in query return type in basho/riak_kv#1382 post TTB merge. Requires basho/riak_pb#185.

[lukebakken]

I'm assuming the change from [] to undefined to mean null is OK?

[hmmr]

I think so. In the original pb terms, undefineds are converted to [] in riak_pb_ts_codec, iirc.

[lukebakken]

Right, but shouldn't this remain unchanged? I confirmed that DESCRIBE does return undefined when using TTB encoding at the moment.

[hmmr]

Hm. Then it is something that came out unexpectedly from the merge. I'll investigate.

[macintux]

Need to make sure the cluster is fully up and running before init_per_suite terminates or else the first test(s) may fail (Brett and I saw this happen).

Suggest rt:wait_until_nodes_ready/1.

[hazen]

• Missing single key GET tests

[hmmr]

@javajolt There is an implicit test for single-key get, in 8daf879#diff-fab6193d0172e564f9e34f4cda49fefdR189 and the foreach loop below.

[hazen]

curl test results:

shorty table create (POST) ... ok
shorty insert (POST) ... ok
shorty select (POST) ... ok
shorty list_keys (GET) ... ok
bad query (lexer error) (POST) ... ok
create table (missing key) (POST) ... ok
create table (POST) ... ok
describe table (POST) ... ok
put some data (POST) ... ok
put some bad data (bad key) (POST) ... ok
put some bad data (bad value) (POST) ... ok
put some bad data (missing value for non-null field) (POST) ... ok
single-key get (field-qualified) (GET) ... ok
single-key get (field-qualified, shuffled) (GET) ... ok
single-key non-existing get (GET) ... ok
single-key non-existing get (extra fields) (GET) ... ok
single-key non-existing get (missing fields) (GET) ... ok
single-key get (bad parameter) (GET) ... ok
single-key non-existing delete (DELETE) ... ok
list_keys (GET) ... ok
select query (POST) ... ok
single-key delete (DELETE) ... ok
select query (one record missing) (POST) ... ok
select query (empty) (POST) ... ok
bad get (wrong table) (GET) ... ok
bad put (nxkey) (PUT) ... ok
bad put (wrong table and parameters) (PUT) ... ok
bad query 1 (GET) ... ok
bad query 2 (PUT) ... ok
bad query 3 (POST) ... ok
bad query 4 (POST) ... ok

[hazen]

👍 146a632