Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moving layer control button to always be with the rest of the map controls #379

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Feb 6, 2025

  • Removing old layer control button in the top right
  • Always show smaller layer control button, bottom right
  • Layer menu behaves like the other leaflet controls so it moves accordingly when the sidebar is expanded.
  • In mobile mode the layer menu opens in the bottom tray as before.

Screenshot from 2025-02-06 10-09-16
Screenshot from 2025-02-06 10-09-28
Screenshot from 2025-02-06 10-09-36


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj popkinj requested review from dawnbcgov and kdbelair February 6, 2025 18:15
@popkinj popkinj linked an issue Feb 6, 2025 that may be closed by this pull request
@kdbelair
Copy link

kdbelair commented Feb 6, 2025

@popkinj looks good! a couple notes:

  • I think we lost some text below "All data layers sourced from GeoBC." Can we include the following updated text with this new link: "Click here to learn more about map layers" https://www2.gov.bc.ca/gov/content?id=703C452C2F8C4B0095AF39CA59B9D1A2

  • Are we updating the basemap icon as part of this PR?

  • The clipping issue on mobile for the top toolbar is still present:
    Screenshot_2025-02-06-11-36-42-110_org mozilla firefox

  • There is a clipping issue on mobile for the basemap selector. Screenshot from my device:

Screenshot_2025-02-06-11-25-02-367_com android chrome

Screenshot from desktop:

basemapclipping_desktop

@popkinj
Copy link
Collaborator Author

popkinj commented Feb 6, 2025

Ah yes... I removed that link because it was going to the now deprecated /guidance link. I fix that.
And yea, I can update the basemap icon. Think we agreed on a globe right?

@kdbelair
Copy link

kdbelair commented Feb 6, 2025

Ah yes... I removed that link because it was going to the now deprecated /guidance link. I fix that. And yea, I can update the basemap icon. Think we agreed on a globe right?

Yes, we agreed on a globe

@popkinj
Copy link
Collaborator Author

popkinj commented Feb 6, 2025

Screenshot from 2025-02-06 14-14-29
Screenshot from 2025-02-06 14-26-32

@popkinj popkinj linked an issue Feb 6, 2025 that may be closed by this pull request
@popkinj
Copy link
Collaborator Author

popkinj commented Feb 6, 2025

Screenshot from 2025-02-06 14-51-31
Screenshot from 2025-02-06 14-52-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 'squished' icons in mobile on 'Contact Us' page Map > Update location of the data layer on map
2 participants