Updated validation checks on FE/BE

bcgov · Feb 7, 2025 · fc90654 · fc90654
1 parent 010160a
commit fc90654
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/app/src/validators/ats.ts b/app/src/validators/ats.ts
@@ -24,7 +24,7 @@ const clientBody = {
 
 const atsEnquirySubmissionFields = {
   addedToATS: Joi.boolean().required(),
-  atsClientNumber: Joi.number().allow(null).max(999999)
+  atsClientNumber: Joi.number().integer().min(0).max(999999).allow(null)
 };
 
 const schema = {

diff --git a/frontend/src/components/housing/enquiry/EnquiryForm.vue b/frontend/src/components/housing/enquiry/EnquiryForm.vue
@@ -2,7 +2,7 @@
 import { Form } from 'vee-validate';
 import { computed, onMounted, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
-import { date, mixed, number, object, string } from 'yup';
+import { boolean, date, mixed, number, object, string } from 'yup';
 
 import {
   CancelButton,
@@ -94,7 +94,8 @@ const intakeSchema = object({
     .label('Assigned to'),
   applicationStatus: string().oneOf(APPLICATION_STATUS_LIST).label('Activity state'),
   waitingOn: string().notRequired().max(255).label('waiting on'),
-  atsClientNumber: number().max(999999).notRequired()
+  addedToATS: boolean().required().label('Authorized Tracking System (ATS) updated'),
+  atsClientNumber: number().min(0).max(999999).notRequired().label('ATS Client #')
 });
 
 // Actions

diff --git a/frontend/src/components/housing/submission/SubmissionForm.vue b/frontend/src/components/housing/submission/SubmissionForm.vue
@@ -131,7 +131,7 @@ const formSchema = object({
   naturalDisaster: string().oneOf(YES_NO_LIST).required().label('Affected by natural disaster'),
   projectLocationDescription: string().notRequired().max(4000).label('Additional information about location'),
   addedToATS: boolean().required().label('Authorized Tracking System (ATS) updated'),
-  atsClientNumber: number().notRequired().max(999999).label('ATS Client #'),
+  atsClientNumber: number().notRequired().min(0).max(999999).label('ATS Client #'),
   ltsaCompleted: boolean().required().label('Land Title Survey Authority (LTSA) completed'),
   bcOnlineCompleted: boolean().required().label('BC Online completed'),
   aaiUpdated: boolean().required().label('Authorization and Approvals Insight (AAI) updated'),