BCeID FN LN Issue Fix #243
Merged
+40
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
sanjaytkbabu
requested review from
kyle1morel,
wilwong89 and
qhanson55
as code owners
wilwong89
approved these changes
Jan 22, 2025
qhanson55
previously approved these changes
Jan 22, 2025
kyle1morel
previously requested changes
Jan 22, 2025
app/src/services/user.ts
Outdated
| @@ -27,12 +27,15 @@ const service = { | |||
| .filter((claims) => claims) // Drop falsy values from array | |||
| .concat(undefined)[0]; // Set undefined as last element of array | |||
|
|
|||
| const firstName = token.given_name.split(' ')[0]; | |||
| const lastName = token.family_name.trim().length > 0 ? token.family_name : token.given_name.split(' ')[1]; | |||
There was a problem hiding this comment.
If someone is named Jim Joe Smith, this would only store Joe as their last name, and Smith would be omitted entirely.
This will also array out of bounds in the possibility a user comes in with only a single word for their given_name and no family_name.
jujaga
previously requested changes
Jan 22, 2025
kyle1morel
force-pushed
the
bugfix/bceid-contact
branch
2 times, most recently
from
8724a87 to
27ff536
Compare
kyle1morel
force-pushed
the
bugfix/bceid-contact
branch
3 times, most recently
from
5d7c5f6 to
1878549
Compare
sanjaytkbabu
commented
Jan 30, 2025
| const contactSchema = object({ | ||
| firstName: string().required().max(255).label('First name'), |
There was a problem hiding this comment.
should we start using i18n for validation schemas?
kyle1morel
force-pushed
the
bugfix/bceid-contact
branch
from
1878549 to
f010853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PADS-436
BCeID was passing both fn and ln in given_name, now we're splitting it on space to fn and ln.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments