Fix for critical screen reader issues, some accessibility enhancements #249
Conversation
wilwong89
requested review from
kyle1morel,
sanjaytkbabu and
qhanson55
as code owners
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
Release 57dc373 deployed at https://pcns-dev-pr-249.apps.silver.devops.gov.bc.ca |
| @@ -10,6 +10,6 @@ const { title } = defineProps<{ | |||
| <template> | |||
| <div class="col-span-12 mb-4 flex items-center"> | |||
| <h4 class="flex-none m-0 pr-4">{{ title }}</h4> | |||
| <Divider /> | |||
| <Divider aria-hidden="true" /> | |||
There was a problem hiding this comment.
Do we want to wrap this component into our own to ensure accessibility requirements aren't missed in the future? It appears numerous times in this PR.
There was a problem hiding this comment.
I'll make the switch. We'll still need to make sure devs remember to use the our wrapper version instead of the primevue lib.
wilwong89
force-pushed
the
feature/screenreader-updates
branch
from
ef66d29 to
5cf1401
Compare
| > | ||
| {{ slotProps.item.text }} | ||
| </div> | ||
| <div | ||
| v-if="slotProps?.item?.iconClass == 'previous'" |
There was a problem hiding this comment.
not sure if it's dumb, but can we have constants declared and check it here? for previous, empty and current?
There was a problem hiding this comment.
The div with the v-if v-else-if stuff is making me wonder if the actual content values inside the div should be yielded as a computed or function instead and put in as a template string, instead of remounting the entire div object - it seems like all the other div attributes are basically identical otherwise.
| <h1 class="mb-0"> | ||
| Welcome to the | ||
| <br /> | ||
| Permit Connect Services | ||
| </h1> |
There was a problem hiding this comment.
Is this something that needs to be in i18n?
| > | ||
| {{ slotProps.item.text }} | ||
| </div> | ||
| <div | ||
| v-if="slotProps?.item?.iconClass == 'previous'" |
There was a problem hiding this comment.
The div with the v-if v-else-if stuff is making me wonder if the actual content values inside the div should be yielded as a computed or function instead and put in as a template string, instead of remounting the entire div object - it seems like all the other div attributes are basically identical otherwise.
|
Looking great! One small change I'd like to suggest:
|
Description
Updated header and navbar to streamline screenreader flow
Updated submission and enquiry intake forms to have proper section headings, proper stepheader buttons
Updated permits detailed page to read out correct statuses
Fix beginning splash page header to read as one sentence
Added alt text to proponent tables
Remove dividers from being read out by screen reader.
PADS-311
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments