Linking ATS numbers to related enquiries #257
Conversation
Coverage Report (Application)
|
Coverage Report (Frontend)
|
wilwong89
force-pushed
the
feature/related-enquiry-ats
branch
4 times, most recently
from
8b35806 to
addbedc
Compare
wilwong89
requested review from
kyle1morel,
sanjaytkbabu and
qhanson55
as code owners
|
The modal that shows up when you click on "search ATS" seems broken..? like the UI and all the layout. New ATS Client modal looks fine. And just some minor tweaks: When it says Client #: Unavailable, can we get rid of the text underline for the word "unavailable." And when clicking on the linked ATS client ID from a related enquiry view, the modal buttons are greyed out, which is good, but when you hover over the "save" button it shows the text underline, can we remove that underline as well? Thank you! |
Looks like the Primevue update from a while ago silently changed the styling and we didn't catch it. Fixed now. |
| @@ -108,6 +125,15 @@ const onAssigneeInput = async (e: IInputEvent) => { | |||
| } | |||
| }; | |||
|
|
|||
| const showUserLinkModelCheck = (values: Enquiry) => { | |||
| if (relatedAtsNumber || values.atsClientNumber) return true; | |||
There was a problem hiding this comment.
reason why not returning false? could we just have
return (relatedAtsNumber || values.atsClientNumber)
| else false; | ||
| }; | ||
|
|
||
| const handleDetailsModalClick = computed(() => (values: Enquiry) => { |
There was a problem hiding this comment.
don't think you need computed here?
| :disabled="!editable" | ||
| @click="atsUserLinkModalVisible = true" | ||
| > | ||
| Search ATS |
There was a problem hiding this comment.
Updated with i18n changes.
| :disabled="!editable" | ||
| @click="atsUserCreateModalVisible = true" | ||
| > | ||
| New ATS Client |
There was a problem hiding this comment.
Updated with i18n changes.
wilwong89
force-pushed
the
feature/related-enquiry-ats
branch
2 times, most recently
from
b10e9f7 to
911f0b3
Compare
…on and enquiry tables for ats_client_number
wilwong89
force-pushed
the
feature/related-enquiry-ats
branch
from
911f0b3 to
2ea0ded
Compare
|
Release 6b9538d deployed at https://pcns-dev-pr-257.apps.silver.devops.gov.bc.ca |
Description
Adding logic to EnquiryView and EnquiryForm components to handle ATS numbers relating to enquiries with related activities.
Prevent enquiries with related activities from changing ATS client numbers or creating new ATS client entries
Show ATS client numbers from related activities if available.
PADS-366
PADS-367
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments