Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BCSC login #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable BCSC login #259

wants to merge 2 commits into from

Conversation

kyle1morel
Copy link
Collaborator

Description

Enables BC Services Card login
Makes adjustments to user data to rely on the sub now. Removes legacy identity_id workarounds for previous Keycloak shenanigans.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Feb 7, 2025

Coverage Report (Frontend)

Totals Coverage
Statements: 46.03% ( 3121 / 6780 )
Methods: 35.27% ( 413 / 1171 )
Lines: 53.76% ( 1808 / 3363 )
Branches: 40.07% ( 900 / 2246 )

Copy link

github-actions bot commented Feb 7, 2025

Coverage Report (Application)

Totals Coverage
Statements: 42.7% ( 1273 / 2981 )
Methods: 36.44% ( 184 / 505 )
Lines: 54.1% ( 805 / 1488 )
Branches: 28.74% ( 284 / 988 )

Copy link

github-actions bot commented Feb 7, 2025

Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically looks good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants