Missing an obvious alias. #2

richardpark-msft · 2022-02-01T23:22:53Z

This repo seems to handle some small values, but lacks the larger values needed to really hit enterprise levels.

NOTE: updating as per @KarishmaGhiya's comment.

KarishmaGhiya

Though your PR is missing a description, I can approve this for you!

benbp · 2022-02-09T00:46:19Z

.zshrc

@@ -209,6 +209,7 @@ alias grb2="git rebase -i HEAD~2"
 alias grb3="git rebase -i HEAD~3"
 alias grb5="git rebase -i HEAD~5"
 alias grbt="git rebase -i HEAD~10"
+alias grbtt="git rebase -i HEAD~1010"


Suggested change

alias grbtt="git rebase -i HEAD~1010"

alias grbtt="git rebase -i HEAD~$(echo "obase=2;10" | bc)

Hardcoding values isn't enterprise-y enough.

I measured this across 10000 runs and your change really drags down the perf. Is this a strict requirement?

Are you the using enterprise version of zsh? If not it will rate limit rc file execution. We only support "zsh for business" subscriptions.

I agree with @benbp

@maorleger - can you clarify?

richardpark-msft · 2022-02-09T00:53:51Z

@chrisradek, I believe you've run into issues with this before, correct?

maorleger

Please make sure we can support all values between 10 and 1010

benbp · 2022-02-09T01:20:22Z

Please make sure we can support all values between 10 and 1010

I would also like us to consider supporting negative values, in order to see what commits we will make in the future. This should rapidly improve our development velocity.

chrisradek · 2022-02-09T01:21:12Z

@richardpark-msft aliasing can be hard 😄

benbp · 2022-02-09T01:23:57Z

This needs an integration test.

richardpark-msft · 2022-02-09T01:41:55Z

This needs an integration test.

I looked but I didn't see an example of that. Is your contributors guide out of date?

richardpark-msft · 2022-02-09T18:16:05Z

@maorleger

Please make sure we can support all values between 10 and 1010

Issue filed: #4

richardpark-msft · 2022-02-09T18:17:10Z

@lmolkova, is it okay if @benbp doesn't have this instrumented properly? TBH, he seems to not care about all of our standards at all.

lmolkova · 2022-02-09T20:41:13Z

should we consider a more future-proof approach so we never confuse anyone with irrelevant history?
alias screwit="git rebase --soft --root && git commit -m "i did it all in one commit"" ?

richardpark-msft · 2022-02-16T00:00:17Z

should we consider a more future-proof approach so we never confuse anyone with irrelevant history? alias screwit="git rebase --soft --root && git commit -m "i did it all in one commit"" ?

Added! Hopefully this will be the feature that sways @benbp to treat this like a real open source project.

.zshrc

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

alzimmermsft · 2022-03-28T19:39:38Z

@maorleger

Please make sure we can support all values between 10 and 1010

Issue filed: #4

I need support for 1011, should I file a new issue or add on to this one?

lmolkova · 2022-03-28T22:05:52Z

@maorleger

Please make sure we can support all values between 10 and 1010

Issue filed: #4

I need support for 1011, should I file a new issue or add on to this one?

@alzimmermsft we track all issues here, just make sure to add a link to the comment explaining your issue in the commit message. You can edit comment as you go to provide more context.

benbp · 2022-04-01T00:10:31Z

@alzimmermsft @lmolkova we may need to cut a new major version for 1011. It may break some users who have taken hard dependencies on this pull request.

KarishmaGhiya · 2022-04-05T20:16:10Z

.zshrc

@@ -209,6 +209,9 @@ alias grb2="git rebase -i HEAD~2"
 alias grb3="git rebase -i HEAD~3"
 alias grb5="git rebase -i HEAD~5"
 alias grbt="git rebase -i HEAD~10"
+alias grbtt="git rebase -i HEAD~1010"
+# Thank you @lmolkova!
+alias screwit="git rebase --soft --root && git commit -m "i did it all in one commit"" 


Suggested change

alias screwit="git rebase --soft --root && git commit -m "i did it all in one commit""

alias screwit="git rebase --soft --root && git commit -m 'i did it all in one commit'"

@KarishmaGhiya is the hero we needed.

benbp · 2022-04-06T18:14:20Z

We did it folks. I will be sending out ship-it awards within the week. Please post your addresses publicly to this pull request thread.

Missing an obvious alias.

8674e5a

richardpark-msft mentioned this pull request Feb 1, 2022

Is this repo taking contributions? #3

Closed

KarishmaGhiya approved these changes Feb 3, 2022

View reviewed changes

benbp reviewed Feb 9, 2022

View reviewed changes

maorleger suggested changes Feb 9, 2022

View reviewed changes

richardpark-msft mentioned this pull request Feb 9, 2022

Please make sure we can support all values between 10 and 1010 #4

Open

Incorporating suggested change from @lmolkova

f6fa727

lmolkova reviewed Feb 16, 2022

View reviewed changes

.zshrc Outdated Show resolved Hide resolved

Update .zshrc

0bac707

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

Updating to logo "classic"

1f25a26

KarishmaGhiya reviewed Apr 5, 2022

View reviewed changes

benbp merged commit 1ba05d6 into benbp:master Apr 6, 2022

richardpark-msft deleted the natural-extension branch June 4, 2022 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing an obvious alias. #2

Missing an obvious alias. #2

richardpark-msft commented Feb 1, 2022 •

edited

Loading

KarishmaGhiya left a comment

benbp Feb 9, 2022

benbp Feb 9, 2022

richardpark-msft Feb 9, 2022

benbp Feb 9, 2022 •

edited

Loading

maorleger Feb 9, 2022

richardpark-msft Feb 9, 2022

richardpark-msft commented Feb 9, 2022

maorleger left a comment

benbp commented Feb 9, 2022

chrisradek commented Feb 9, 2022

benbp commented Feb 9, 2022

richardpark-msft commented Feb 9, 2022 •

edited

Loading

richardpark-msft commented Feb 9, 2022

richardpark-msft commented Feb 9, 2022

lmolkova commented Feb 9, 2022

richardpark-msft commented Feb 16, 2022

alzimmermsft commented Mar 28, 2022

lmolkova commented Mar 28, 2022 •

edited

Loading

benbp commented Apr 1, 2022

KarishmaGhiya Apr 5, 2022

chrisradek Apr 5, 2022

lmolkova Apr 5, 2022

benbp commented Apr 6, 2022

	alias grbtt="git rebase -i HEAD~1010"
	alias grbtt="git rebase -i HEAD~$(echo "obase=2;10" \| bc)

	alias screwit="git rebase --soft --root && git commit -m "i did it all in one commit""
	alias screwit="git rebase --soft --root && git commit -m 'i did it all in one commit'"

Missing an obvious alias. #2

Missing an obvious alias. #2

Conversation

richardpark-msft commented Feb 1, 2022 • edited Loading

KarishmaGhiya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benbp Feb 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richardpark-msft commented Feb 9, 2022

maorleger left a comment

Choose a reason for hiding this comment

benbp commented Feb 9, 2022

chrisradek commented Feb 9, 2022

benbp commented Feb 9, 2022

richardpark-msft commented Feb 9, 2022 • edited Loading

richardpark-msft commented Feb 9, 2022

richardpark-msft commented Feb 9, 2022

lmolkova commented Feb 9, 2022

richardpark-msft commented Feb 16, 2022

alzimmermsft commented Mar 28, 2022

lmolkova commented Mar 28, 2022 • edited Loading

benbp commented Apr 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benbp commented Apr 6, 2022

richardpark-msft commented Feb 1, 2022 •

edited

Loading

benbp Feb 9, 2022 •

edited

Loading

richardpark-msft commented Feb 9, 2022 •

edited

Loading

lmolkova commented Mar 28, 2022 •

edited

Loading