Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8.0.2 #422

Closed
wants to merge 5 commits into from
Closed

Upgrade to .NET 8.0.2 #422

wants to merge 5 commits into from

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Feb 16, 2024

Requirement:

Side effects:

@jonashendrickx jonashendrickx requested a review from a team as a code owner February 16, 2024 13:03
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4562fbe) 30.70% compared to head (255aa4a) 30.70%.

Files Patch % Lines
src/AdminConsole/Program.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   30.70%   30.70%           
=======================================
  Files         479      479           
  Lines       24618    24618           
  Branches      818      817    -1     
=======================================
+ Hits         7558     7559    +1     
  Misses      16962    16962           
+ Partials       98       97    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing this internally, we will wait a bit until going up to see if the dotnet format issues gets sorted out.

Blocking with a "Request changes" until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants