settings-committer: INFO instead of error when no settings changed #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On reboot, for example, we may not have had any settings change. We don't want
that to cause a service startup failure or log a confusing message. If other
services failed to PATCH settings changes, they'll fail themselves, so the
system will still reflect failure when it needs to.
Testing done:
Before, after a reboot, settings-committer would fail and show its error on console:
After, no error:
Failures still cause the system to... fail, as expected.