Cross build golang in CI #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
force-pushed
the
cross-build-golang
branch
from
927f5d6 to
5447964
Compare
The go compiler needs CGO enabled and a reference to the cross compiler toolchain in order to cross-build.
cbgbt
force-pushed
the
cross-build-golang
branch
from
5447964 to
6f0facc
Compare
yeazelm
approved these changes
Jan 4, 2025
jpculp
approved these changes
Jan 6, 2025
|
Provide additional CFLAGS suggested by @jpculp |
cbgbt
force-pushed
the
cross-build-golang
branch
from
52c4d21 to
c9b0442
Compare
jpculp
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
cargo-crossbuilds ofkrane-staticwere failing. This:krane-staticcargo-crossfor PRs to twoliter to catch such errors ahead of time in the future.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.