rpm2kit: drop unnecessary "--all" argument #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dnf4, "--all" is the long way of writing "*", which is also the default if no argument is specified. It's no longer supported in dnf5, so just get rid of it. Signed-off-by: Ben Cressey <bcressey@amazon.com>
sam-berning
approved these changes
Jan 7, 2025
cbgbt
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
In dnf4, "--all" is the long way of writing "*", which is also the default if no argument is specified.
It's no longer supported in dnf5, so just get rid of it.
Testing done:
Built kits with a newer SDK based on Fedora 41, which uses dnf5.
Verified that the list of RPMs in the kit is still logged:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.