twoliter: move docker version check to buildsys #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twoliter does not require access to the docker daemon for publication workflows (e.g. publishing AMIs or SSM parameters.) To accomodate environments which do not provide access to the docker daemon for these workflows, we only make assertions about the system's docker daemon before using `docker build`.
bcressey
approved these changes
Jan 22, 2025
sumukhballal
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Twoliter does not require access to the docker daemon for publication workflows (e.g. publishing AMIs or SSM parameters.) To accomodate environments which do not provide access to the docker daemon for these workflows, we only make assertions about the system's docker daemon before using
docker build.Testing done:
dockerbinary to path which reported an unsupported version andTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.